Fix for copying cookies when the browser is running. #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Contributor
|
winapi would probably better than doing taskkill imo |
|
no need for winapi. no need for task kill. no need to copy over files. u can just read the cookies db even when the browser is running... |
Contributor
|
bro ud need to kill the browser or kill the handle or do it in memory... u can find the db in mem |
no no need to kill handle. no need to find db in mem. no need for winapi. it al comes down to a deeper understanding of the sql driver in golang |
Contributor
|
again u can do the query in mem bro idk what ur doing and there multiple methods lol |
Contributor
|
And im aware of the query ur doing btw. But theres multiple methods lol... but its whatever lol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a check for launching browsers, if yes - then closes and rechecks. If there are none, then just skips on.
I'm not sure that it can work on all systems and browsers, but I added a standard list of processes.
Type of change
How Has This Been Tested?
I conducted testing on both virtual machines like apponfly and virtualbox (turning off anti-VM for a while)